Our FamilyForum

FamilyForum Documentation & Help => FamilyForum Features & Guidelines => Code & Stuff => Topic started by: Ken on November 30, 2015, 08:39:16 AM

Title: Forum Files Refresh Upcoming.
Post by: Ken on November 30, 2015, 08:39:16 AM
As time goes by the SMF and TinyPortal software files that Our FamilyForum is built upon become littered with extra codes, mostly because I load up so many Modifications and because I'm forever making changes and testing stuff.

So, over on TP, Illori, who is our Lead Developer for the TP code has a new release just about ready to go and when it goes public I'm thinking that before I install it here we need a fresh copy of SMF installed so as to get rid of all those old lines of code that keep causing errors to pop up in the logs. Plus, there is at least one of those Mods that I can't uninstall now because of the errors.

More details laters.
Title: Re: Forum Files Refresh Upcoming.
Post by: Skhilled on November 30, 2015, 08:42:22 AM
I need to do mine too. Then I'll probably put TP back on it.
Title: Re: Forum Files Refresh Upcoming.
Post by: Ken on November 30, 2015, 08:53:12 AM
I need to do mine too. Then I'll probably put TP back on it.

Good deal Steve.  :thumbup:



... we all need to be running TP.  laughing7
Title: Re: Forum Files Refresh Upcoming.
Post by: Skhilled on November 30, 2015, 08:55:19 AM
I know SP can have some issues when uninstalling it and is why I need to do it then. Waiting for the, hopefully, final release...version #2948.  :whistle1:
Title: Re: Forum Files Refresh Upcoming.
Post by: Ken on November 30, 2015, 09:01:09 AM
I know SP can have some issues when uninstalling it and is why I need to do it then. Waiting for the, hopefully, final release...version #2948.  :whistle1:

 :funny:
Title: Re: Forum Files Refresh Upcoming.
Post by: Mick on November 30, 2015, 01:52:46 PM

As time goes by the SMF and TinyPortal software files that Our FamilyForum is built upon become littered with extra codes, mostly because I load up so many Modifications and because I'm forever making changes and testing stuff.


Should read: As time goes by the SMF and TinyPortal software files that Our FamilyForum is built upon become littered with extra codes, only because I load up so many Modifications and because I'm forever making changes and testing stuff.  :rofl2


Waiting for the, hopefully, final release...version #2948.  :whistle1:


Oi, you taking the P?  I thought it was 2949.  laughing7
Title: Re: Forum Files Refresh Upcoming.
Post by: Ken on November 30, 2015, 03:12:55 PM

As time goes by the SMF and TinyPortal software files that Our FamilyForum is built upon become littered with extra codes, mostly because I load up so many Modifications and because I'm forever making changes and testing stuff.


Should read: As time goes by the SMF and TinyPortal software files that Our FamilyForum is built upon become littered with extra codes, only because I load up so many Modifications and because I'm forever making changes and testing stuff.  :rofl2


Waiting for the, hopefully, final release...version #2948.  :whistle1:


Oi, you taking the P?  I thought it was 2949.  laughing7

 :rofl2

Title: Re: Forum Files Refresh Upcoming.
Post by: Skhilled on December 01, 2015, 09:35:03 AM
LOL
Title: Re: Forum Files Refresh Upcoming.
Post by: Ken on December 03, 2015, 12:19:06 PM
The file refresh has started.  :thumbup:
Title: Re: Forum Files Refresh Upcoming.
Post by: Ken on December 03, 2015, 05:37:03 PM
The SMF files have been replaced.
There's an issue with a Mod that was installed previously, 'SayThanks', it's filling up the error log so it will need attention before doing anything else. Looks like I'll need to do a little reverse engineering and remove all the leftover code from the files.

Code: [Select]
http://www.ourfamilyforum.org/FamilyForum/index.php?topic=3786.0
Apply Filter: Only show the errors with the same message
8: Undefined index: saythanks_ajax_error
Apply Filter: Only show the errors from this file
File: /home/ourfamil/public_html/FamilyForum/Themes/default/SayThanks.template.php
Line: 40
Apply Filter: Only show the error messages of this member Ken
Apply Filter: Only show the error messages of this IP address 67.45.113.191 
  Reverse chronological order of list Today at 05:21:58 PM
Apply Filter: Only show the error messages of this session f452ac1f62890290ea9e2014301e4712
Apply Filter: Only show the errors of this type Type of error: Undefined
Title: Re: Forum Files Refresh Upcoming.
Post by: Mick on December 03, 2015, 05:55:34 PM
The SMF files have been replaced.
There's an issue with a Mod that was installed previously, 'SayThanks', it's filling up the error log so it will need attention before doing anything else. Looks like I'll need to do a little reverse engineering and remove all the leftover code from the files.

Code: [Select]
http://www.ourfamilyforum.org/FamilyForum/index.php?topic=3786.0
Apply Filter: Only show the errors with the same message
8: Undefined index: saythanks_ajax_error
Apply Filter: Only show the errors from this file
File: /home/ourfamil/public_html/FamilyForum/Themes/default/SayThanks.template.php
Line: 40
Apply Filter: Only show the error messages of this member Ken
Apply Filter: Only show the error messages of this IP address 67.45.113.191 
  Reverse chronological order of list Today at 05:21:58 PM
Apply Filter: Only show the error messages of this session f452ac1f62890290ea9e2014301e4712
Apply Filter: Only show the errors of this type Type of error: Undefined

Thought you uploaded fresh files Ken, there shouldn't be any left over code.  You didn't replace the theme files which is why you're getting some errors, they still have the edits in them.  :wink:
Title: Re: Forum Files Refresh Upcoming.
Post by: Ken on December 03, 2015, 07:29:22 PM
Yes, the custom themes have been removed now... just checked all the file edits for that mod and the files were clean, still working on it, gonna check to see if there are any extra files laying around.

Found it!  :banana:
'SayThanks.php' was still lurking in the Sources directory.   laughing7
Title: Re: Forum Files Refresh Upcoming.
Post by: Ken on December 03, 2015, 09:22:13 PM
Got it sorted, no errors now.
Title: Re: Forum Files Refresh Upcoming.
Post by: Skhilled on December 04, 2015, 09:50:11 AM
Ken, when you uninstall mods or just upload new SMF files you should also run the Fix Packages Tool from SMF to make sure the hooks are also removed:

http://download.simplemachines.org/?tools

I've found that just uploading new SMF files alone may not remove all of the hooks...since SMF uses the hooks system now. I think it depends on how the mod(s) are coded. You can either do it before or after you upload the new SMF files and it should work.

Hmmmm, need to add that to my docs...
Title: Re: Forum Files Refresh Upcoming.
Post by: Ken on December 04, 2015, 10:10:41 AM
Thanks Steve, I'll try to remember that for the next time.

Or do it now and reload the mods after that?
Title: Re: Forum Files Refresh Upcoming.
Post by: Skhilled on December 04, 2015, 10:13:45 AM
you can do it now but it will remove the hooks from any mods you may have already installed. It will not remove the mod code edits...just the hooks. So, if you've already installed any mods then you will have to reinstall them again and take a chance on getting multiple coding from the mods.

If you did not install any mods yet or just want to start fresh then run it and upload new SMF files and then install your mods.
Title: Re: Forum Files Refresh Upcoming.
Post by: Ken on December 04, 2015, 10:17:25 AM
I may do a fresh run at it and try to get the SMF upload right this time.
Title: Re: Forum Files Refresh Upcoming.
Post by: Skhilled on December 04, 2015, 10:29:31 AM
The hooks are a good thing but can be a bit of trouble when uninstalling mods if not coded to remove them properly. You know you've got clean files but why do you still see errors or parts of a mod???  shocked028