Topic: Arcade testing: Round #1

[Ken (OP)]

This is for working on a draft for a reply to Underdog over on the SMF Arcade site.

You can reply or comment as you wish, but I'm gonna be doing a lot of editing to this first post as I work through the check list that UD posted on SMF Arcade.


... UD sez:
I have updated it again so that now it creates and/or edits the settings variables for SMF Arcade.
Can you please test it like you originally did to see if this stops those errors?
Thanks.

- fresh install SMF 1 ...dropped all tables, deleted all files for a completely clean install.
- install E-Arcade v259 ... this gave me two pages of errors like these two:

http://www.ourfamilyforum.org/tp098/index.php?action=arcade
Apply Filter: Only show the errors with the same message
2: Invalid argument supplied for foreach()
File: /home/kenkayjm/public_html/tp098/Sources/ArcadeBlocks.php
Line: 127

Apply Filter: Only show the error messages of this URL http://www.ourfamilyforum.org/tp098/index.php?action=arcade
Apply Filter: Only show the errors with the same message
8: Undefined variable: cats
File: /home/kenkayjm/public_html/tp098/Sources/ArcadeBlocks.php
Line: 820

- install gamepack ... GamePackAO1, gave 4 errors on install:

http://www.ourfamilyforum.org/tp098/index.php?action=arcade
2: Invalid argument supplied for foreach()
File: /home/kenkayjm/public_html/tp098/Sources/ArcadeBlocks.php
Line: 720

Apply Filter: Only show the error messages of this URL http://www.ourfamilyforum.org/tp098/index.php?action=admin;area=managearcade;sa=files;do=stageone
2: Invalid argument supplied for foreach()
File: /home/kenkayjm/public_html/tp098/Sources/ManageArcade.php
Line: 906

- record some scores and save some favorites ... worked OK, but gave a couple of "Invalid argument supplied for foreach()" errors in the log.
- uninstall E-Arcade v259 ... done.
- Delete E-Arcade v259 ... done.
- Install the tool ... done.
- Uninstall the tool ... done, gave these errors in the log.

http://www.ourfamilyforum.org/tp098/index.php?action=packages;sa=install2;package=convert-eac259-to-smfac-2018_BETA1.zip
Apply Filter: Only show the errors with the same message
2: mysql_free_result(): supplied argument is not a valid MySQL result resource
File: /home/kenkayjm/public_html/tp098/Packages/temp/convertmyarcade.php
Line: 17

8: Undefined variable: doit5
File: /home/kenkayjm/public_html/tp098/Packages/temp/convertmyarcade.php
Line: 17
   
2: mysql_free_result(): supplied argument is not a valid MySQL result resource
File: /home/kenkayjm/public_html/tp098/Packages/temp/convertmyarcade.php
Line: 16
   
8: Undefined variable: doit4
File: /home/kenkayjm/public_html/tp098/Packages/temp/convertmyarcade.php
Line: 16
   
2: mysql_free_result(): supplied argument is not a valid MySQL result resource
File: /home/kenkayjm/public_html/tp098/Packages/temp/convertmyarcade.php
Line: 15
   
8: Undefined variable: doit3
File: /home/kenkayjm/public_html/tp098/Packages/temp/convertmyarcade.php
Line: 15
   
2: mysql_free_result(): supplied argument is not a valid MySQL result resource
File: /home/kenkayjm/public_html/tp098/Packages/temp/convertmyarcade.php
Line: 14
   
8: Undefined variable: doit2
File: /home/kenkayjm/public_html/tp098/Packages/temp/convertmyarcade.php
Line: 14
   
2: mysql_free_result(): supplied argument is not a valid MySQL result resource
File: /home/kenkayjm/public_html/tp098/Packages/temp/convertmyarcade.php
Line: 13
   
http://www.ourfamilyforum.org/tp098/index.php?action=packages;sa=install2;package=convert-eac259-to-smfac-2018_BETA1.zip
8: Undefined variable: doit1
File: /home/kenkayjm/public_html/tp098/Packages/temp/convertmyarcade.php
Line: 13

- Install SMF Arcade v2018 ... done, played one game and it worked as expected. No new errors in the log.

I want to see if it works without errors doing this process.

This first scenario was completed and the results posted to the topic on SMF Arcade.


Then try this:

- fresh install SMF 1
- install E-Arcade v259
- install gamepack
- record some scores and save some favorites
- uninstall E-Arcade v259
- Delete E-Arcade v259
- Install SMF Arcade v2018
- Uninstall SMF Arcade 2018
- Install the tool
- Uninstall the tool
- Install SMF Arcade v2018


Let's see if both scenarios work without errors (for both of us).

[Underdog]

The second scenario will not work properly on that version you were testing because I forgot to put global $modSettings in the main function. 

You'll have to download the latest from SMFAC

I've tested it for both scenarios and it works well and is error free.
btw - install errors are fixed.

Thanks.

[Ken (OP)]

Edited copy of the second scenario as posted on SMFA:

---------------------------------------

The e-arcade errors are from prior to games being installed and/or any scores being recorded.  Plus it's uninstall needs adjustment as to not throw 2 errors.

I updated the tool once more...

This version works for both scenarios and throws no errors for me.

OK.
Scenario #2 completed:
---------------------------------------

Then try this:

- fresh install SMF 1 ... done.
- install E-Arcade v259 ... done, with errors.

http://www.ourfamilyforum.org/tp098/index.php?action=packages;sa=install2;package=E-Arcade2.5.9_update_SMF1.1.11.zip
8: Undefined variable: upgrade
File: /home/kenkayjm/public_html/tp098/Packages/temp/package_install.php
Line: 304
   
Apply Filter: Only show the error messages of this URL http://www.ourfamilyforum.org/tp098/index.php?action=packages;sa=install;package=E-Arcade2.5.9_update_SMF1.1.11.zip;sesc
8: Undefined index: package_readme
File: /home/kenkayjm/public_html/tp098/Sources/Packages.php
Line: 296

- install gamepack ... done, with errors.

http://www.ourfamilyforum.org/tp098/index.php?action=admin;area=managearcade;sa=files;do=stageone
Apply Filter: Only show the errors with the same message
2: Invalid argument supplied for foreach()
File: /home/kenkayjm/public_html/tp098/Sources/ManageArcade.php
Line: 906   

Apply Filter: Only show the error messages of this URL http://www.ourfamilyforum.org/tp098/index.php?action=admin;area=managearcade;sa=files;file=GamePackA01.zip
2: Invalid argument supplied for foreach()
File: /home/kenkayjm/public_html/tp098/Sources/ManageArcade.php
Line: 826

2: Invalid argument supplied for foreach()
File: /home/kenkayjm/public_html/tp098/Sources/ManageArcade.php
Line: 826

- record some scores and save some favorites ... done, with errors.

2: Invalid argument supplied for foreach()
File: /home/kenkayjm/public_html/tp098/Sources/ArcadeBlocks.php
Line: 720

2: Invalid argument supplied for foreach()
File: /home/kenkayjm/public_html/tp098/Sources/ArcadeBlocks.php
Line: 634

2: Invalid argument supplied for foreach()
File: /home/kenkayjm/public_html/tp098/Sources/ArcadeStats.php
Line: 256

2: Invalid argument supplied for foreach()
File: /home/kenkayjm/public_html/tp098/Sources/ArcadeBlocks.php
Line: 652

2: Invalid argument supplied for foreach()
File: /home/kenkayjm/public_html/tp098/Sources/ArcadeBlocks.php
Line: 786
   
2: Invalid argument supplied for foreach()
File: /home/kenkayjm/public_html/tp098/Sources/ArcadeStats.php
Line: 178
   
8: Undefined index: arcadegotd
File: /home/kenkayjm/public_html/tp098/Sources/Subs-Arcade.php
Line: 89

8: Undefined index: arcade_last_update
File: /home/kenkayjm/public_html/tp098/Sources/Subs-Arcade.php
Line: 1264

- uninstall E-Arcade v259 ... done, with errors.

2: unlink(/home/kenkayjm/public_html/tp098/installArcade.php) [<a href='function.unlink'>function.unlink[/url]]: No such file or directory
File: /home/kenkayjm/public_html/tp098/Sources/Subs-Package.php
Line: 1047
   
Apply Filter: Only show the error messages of this URL http://www.ourfamilyforum.org/tp098/index.php?action=packages;sa=uninstall2;package=E-Arcade2.5.9_update_SMF1.1.11.zip
2: unlink(/home/kenkayjm/public_html/tp098/Sources/ArcadeInstall.php) [<a href='function.unlink'>function.unlink[/url]]: No such file or directory
File: /home/kenkayjm/public_html/tp098/Sources/Subs-Package.php
Line: 1047

- Delete E-Arcade v259 ... done.
- Install SMF Arcade v2018 ... done, with errors on the install finished page. (no errors in the forum error log)

SMF Arcade 2.0.0 Installer
Creating tables
Error report! (This means somehing went wrong)
Table 'smf_arcade_games' already exists
Table 'smf_arcade_personalbest' already exists
Table 'smf_arcade_scores' already exists
Table 'smf_arcade_categories' already exists
Table 'smf_arcade_favorite' already exists
Table 'smf_arcade_rates' already exists
Inserting default permissions
Success with no errors!
Inserting default settings
Success with no errors!
Finishing
Error report! (This means somehing went wrong)
Unknown column 'catName' in 'field list'
Package was installed. If you have SMFArcade 1.x installed you can import games and scores now

- Uninstall SMF Arcade 2018 ... done.
- Install the tool ... done.
- Uninstall the tool ... done.
- Install SMF Arcade v2018 ... done.

NOTES:
Fresh db.
New SMF files (dumped all of the old files, not just an overwrite).
New copy of the converter.
At each step any error that were in the forum error log were removed after that step was completed.
On steps where no error is mentioned there were no errors in the log.
At the end of the entire process the SMF Arcade 2.0.18 appears to work as expected, with scores, favorites and ratings transferred over from the E-Arcade.
And with no new errors in the log.

[Underdog]

I forgot to add that we need to test games with different save types to see if it sets them proper.


This is the part I'm working on now in the smf 2 version btw... E-Arcade figures out the save type when the game actually saves a score.. SMF Arcade uses a value stored in the db... so I just wrote a routine that scans for certain files of each game to determine their save types.. Unfortunately atm it can only detect 3 different types ipb, ipb32 and smf1.. any other type will have to be manually adjusted.  This may change as I am going to investigate mochi games to see if they have extra files I can detect because I do not have any of those type games.
I can also add the phpbb if Niko actually considers a request I put in for an edit for that.

 

[Skhilled]

I can also add the phpbb if Niko actually considers a request I put in for an edit for that.

That is a good idea.

[Underdog]

I can also add the phpbb if Niko actually considers a request I put in for an edit for that.

That is a good idea.

Well... it's an ok idea for smf arcade I suppose..
It doesn't really apply here because no one using e-arcade would have phpbb games set up as I suggested.  :disted: